Handle styling of varying amounts of DOJO exercise previews #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bryanjenningz
commented
Sep 23, 2022
| /> | ||
| ))} | ||
| </div> | ||
| {chunk(mockExercisePreviews, 3).map((exercisePreviewChunk, i) => ( |
There was a problem hiding this comment.
This works well for 1000px width screens and above. We'll need to handle smaller screens in the future when the designs are ready.
|
Closing this pull request because I created a new pull request that makes the DOJO exercise list responsive to all screen widths: #2342 |
bryanjenningz
deleted the
handle-variable-amount-of-exercise-previews
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some of the styling for the DOJO exercise previews so that they look good with any amount.
With 8 exercise previews:
With 4 exercise previews:
How to test:
This is a part of #2251